-
nsITobin
-
nsITobin
now I will eat my chicken which I been not doing
-
nsITobin
WG9s: sup
-
WG9s
well i seem to have resolved my lame issue with you patches ahd it all ready to run builds to test when suddenly becuase trying to get 2.53.19 out of the door this weekend I was asked to do some test builds so doing that. I have what i thnk should work with your builds all set to run tonight if I cant find time to swuese it in later
-
nsITobin
WG9s: please don't prioritize my witchcraft-central patches over 253
-
nsITobin
should have named the repo that lol
-
WG9s
was exactly my thought
-
nsITobin
assuming I have my part right my patches will be refreshed over time so (hopefully) in a state where you can just grab em however is best for you.. In my second tag on the repo I did list what each patch does and link to the raw file for you.. I intend to keep doing that if it is helpful
-
nsITobin
rooooughly eq to the patch section on your site
-
WG9s
yes but seems (and could be because of my antiquated mercerial version) some of your payches fail when i do an hg import (which is how i usually do my local stuff in case it deos stuff that does not work with pach) in this case the patches afil with hg import but are fine with patch so i temorarily altered my automation script to apply my local stuff to use patch rather than hg import
-
nsITobin
doesn't that mean you have to reset the repo far more often?
-
WG9s
i find thngs that either add or remove files and especially if they rename files and then also alrer the code work better with hg import thatn with patch
-
nsITobin
I mean I already have to cause I am learning and it is a slog
-
WG9s
but i think what I currently have so
wg9s.com/comm-central/patches has the patch files
wg9s.com/comm-central/patches/patchlist has the equiv of the series file for mozilla-central and
wg9s.com/comm-central/patches/patchlist-cc has the equiv of the series file for comm-central
-
nsITobin
-
WG9s
i anm just learning also and sometimes it is not learning about tech thngs it is learinin how to get along with individulas you need to interface with on better terms
-
nsITobin
is the revised patch for nsSuiteApp
-
nsITobin
not entirely happy with it
-
nsITobin
i think i should redo it according to the bug and diff not reuse nsMailApp even tho its a good cheat and likely doesn't matter
-
WG9s
seemed reason i tried to do a new patch on top of mine was to weperate the parts that fixt thiings fomr the stuff trying to make it look more like the TB code because of surce format reformatting
-
WG9s
frg_Away: alsays resited this type of change becasue mides things harder to backport to 2.53 untell we do the same tree-wide reformat there.
-
nsITobin
i prefer ns style over clang
-
nsITobin
as well
-
WG9s
but I decided unlikely toever backport this to 2.53 and to matian it oncentral is so mch easier if this file the TB one and the FIrefos one are all using the same coding standard
-
nsITobin
but it may just have to eventually be something we all have to accept because it just makes things smoother
-
WG9s
like i said not important is formated same as 2.53 ad is formatted the same as the exiv Firefox and TB versions of the file
-
nsITobin
but mah aesthetics :P
-
WG9s
so that you can diff the and figure out what is going on withoout having to figure out that some of this si just formatting changes
-
WG9s
so a case where i am overriding frg_Away and will probably just land this on central gitlab patch queue if it ssems to work
-
WG9s
anyway like i said might not get back to this til tomoorrow becuase of stuff i am trying to do to help with the 2.53.19 release
-
WG9s
nsITobin: that was one of the problems. never was an ns style the ns idea was maess of modules and ehach module owner was the person who could do super-reviews and defind the coding stle for that module so every module seemed to have different rules.
-
WG9s
so like in some modules you caould do perfecly legal c code. like
-
WG9s
if *<condition>)
-
WG9s
do this;
-
WG9s
else;
-
WG9s
do this;
-
WG9s
but in toher modules had to do
-
WG9s
if (<condition>) {
-
WG9s
do this;
-
WG9s
} else {
-
WG9s
do this;
-
WG9s
}
-
WG9s
and i secresed up the first one should have been
-
WG9s
if (<condition>)
-
WG9s
do this;
-
WG9s
else
-
WG9s
do this;
-
WG9s
that is the c ws to do this the other has to do with writing c code that looke like JavaScript
-
WG9s
if only one line the braces are just stupid
-
nsITobin
internet issues
-
frg_Away
hi nsITobin
-
nsITobin
I hope wg9s doesn';t think I ragequit .. the internet is having issues and spectrum is like saying its my router even tho all their tests are identical NOW we have to go into san antonio proper to get their crap .. I am gonna laugh when it is the same or worse than my reliable gigabit rooter
-
nsITobin
frg_Away:
-
nsITobin
they had me disconnect my router and direct connect for them to tell me to run speedtest.net
-
nsITobin
ridiclous
-
nsITobin
and .. identical results with spectrum's ideal server
-
tomman
ISPs suck, film at 11
-
nsITobin
!
-
tomman
in the meanwhile my backup DSL and main phone line has been dead for 2 weeks
-
tomman
absolutely ZERO response from the state telco
-
nsITobin
its been pretty junk since that last outage like 3 weeks ago
-
nsITobin
barely get any upload
-
nsITobin
download SEEMS largely fine but upload is abysmal and pings
-
nsITobin
irc had a ping time of like 20 seconds before I disconned
-
tomman
oof, that's almost Venezuelan 3G spec
-
nsITobin
some servers i wasn't even getting dsl speeds
-
nsITobin
others full 360megaBITS
-
nsITobin
do these techs not understand how networking works?
-
nsITobin
am I the stupid one for asking that and expecting them too?
-
nsITobin
lol
-
nsITobin
to*
-
nsITobin
be back
-
nsITobin
well that was a disaster
-
nsITobin
and there is no control over anything
-
nsITobin
oh yeah
-
nsITobin
ha ha ha
-
nsITobin
its the same .. actually slightly worse than my reliable gigabit router
-
nsITobin
well we have the pos for a week then I think I am gonna have the account swittched over into my name and get promo pricing locked in for 2 years for now I hooked my own router to their router which they read as an HP printer.. kinda cause I stole an HP printer's mac address from a junked one
-
nsITobin
anyway sup
-
nsITobin
sometimes I feel fate does not want me working on anything on central
-
nsITobin
like its taboo
-
frg_Away
´well when it comes to central or SeaMonkey source fate is in your hand :)
-
nsITobin
must be a slow update then
-
nsITobin
lol
-
nsITobin
sucks didn't get anything actually accomplished
-
nsITobin
today
-
nsITobin
well except jumping through spectrum's hoops
-
frg_Away
Everything will be better on github... not ...
-
nsITobin
!
-
nsITobin
the spectrum router has a hacked version of openwrt they hacked to remove all user functionality and install their backdoor fetch service that grabs configuration off their servers set by their app.. anything more i poke into for answers is likely gonna get me flagged
-
nsITobin
and not having internet would be a slight hamper on contribution I suspect
-
nsITobin
;)
-
frg_Away
well aligned 2.53 a bit more with wip and otherwise. But only build fixes. js wip is still in Limbo. Now at mid 68 with Spidermonke wipy but 2.53.19 next.
-
nsITobin
I am still game for trying a JS engine transplant
-
frg_Away
Not possible without breaking every classic add-on
-
frg_Away
If you look at the wip series you see what I left out. Some of the compartment to realm stuff might go in later but others will just plain break stuff.
-
frg_Away
anyway nighty night
-
nsITobin
oven beeped
-
nsITobin
oh rest well frg