-
WG9s
cant be tomman because it ways he is no venezuala time
-
WG9s
wrong channel
-
tomman
20:56 VET
-
tomman
early to be late~
-
WG9s
is that like easy to be hard?
-
» WG9s says yes, that was a Three Dog Night reference!
-
nsITobin
good morning #seamonkey
-
WG9s
good morning nsITobin
-
nsITobin
just syncing the m-c part so its a str8 copypaste for you
-
nsITobin
have to re-checkout central tho luckily I have this nifty hg bundle laying around to make it less painful
-
nsITobin
WG9s: had to see what qfinish does .. it does exactly what it says it would lol
-
WG9s
qgoto is an interesting one i found out about recently
-
nsITobin
i been largely using the GUI but also doing it on cli too a little
-
WG9s
ti dcide which direction needs to go in the qudu and either does a qpush or a wpop to get there
-
WG9s
is good for refrshing you an do an hg qgoto then an hg qrefresh and then apush the rest of the queue
-
nsITobin
if you know the absolute basic concept of a stack.. its not that hard but still visualizing it as well as the GUI does.. is still difficult
-
nsITobin
I am enjoying the flexability of it
-
WG9s
useful if trying to refresh more that one patch
-
WG9s
so you don;t have to keep checking the series file to see if fro where you are do you need a qpush or qpop to get to the next one tht needs rebasing
-
WG9s
got that from frg out chief fuzz fixer in our patch queue
-
nsITobin
get this pass on the series stuff done for central then I dunno what my next thing is.. may go to the store lol
-
WG9s
the 2.53 patch queues are huge
-
nsITobin
I am anxious for you to attempt to build it and see it "run"
-
nsITobin
I still have to finish cleaning up my wip overlaid patches so they are more spiffy as well as split the go places menu patch
-
nsITobin
also repack those bundles.. zstd is too damn slow
-
nsITobin
this weekend I HAVE to get some php done
-
WG9s
nsITobin: let me know when and how to pick them up. i guess you could put them on the system you added my account on someplace ahd give me read access.
-
WG9s
btw can i rm those tar files or do you still need them?
-
nsITobin
i haven't grabbed them yet
-
nsITobin
WG9s: RESOLVED FIXED
dpaste.org/ZKKRX/raw
-
nsITobin
need to get afterburst to change the rdns
-
nsITobin
...
-
nsITobin
-
WG9s
nsITobin: what would be easiest for me to dael with would be like either a tar or zip file with all the patches and a series file wit the order to add. if there are mozilla-central patches besids comm-central patches then either seperate folders or seperate files to keep the mozilla-central and comm-central patches seperte, but actually could be all in one and just have a mozilla-series...
-
WG9s
...file and a comm=series file would also work just fine for me.
-
nsITobin
well then the easiest for me then is to split this into two repos wip and central then gogs can take care of that for us ;)
-
nsITobin
or just clone the original and work from it
-
nsITobin
save my fancy ass crap for 253 ;)
-
nsITobin
central is complicated as it is.. simplification of dealing with it is best ye stand by
-
WG9s
btw you whould know that i have this page on my webserver.
wg9s.com/comm-central tat documents stuff for my comm-central builds. I used to be advertised more until the bulds became so non-useful that i killed the advertisement and bsicall only frg and I have actually needed to know about its exsistant.
-
nsITobin
I knew about it.. tho its been a while since I seen it
-
nsITobin
I figured you stopped producing them except as needed
-
nsITobin
heh technically that can still be true just an underestimation on need lol
-
nsITobin
are those generated indexes or custom autoindex templates?
-
WG9s
nsITobin: what i do for 2.53 is I have this tar file that I created from doing hg clones --noupdate to create so works even better that hg bundles. if i need to start over from new clone equiv I just untar this file and then do an hg pull; hgupdate on each of the repos in the tar file before appying the gitlab patch qeues
-
nsITobin
so focused on what hg can do i forgot git is very useful for things as well
-
WG9s
so if it help you at all that 2.53 patch queue s here
wg9s.com/comm-253/build/comm-253.tar.xz
-
WG9s
so creates a comm-253 directory is a mozilla and l10n repo there and then under mozilla is a comm repo
-
WG9s
if i were starting from scratch might have had a different directoy structure but when canged form comm on top to mosilla on top this structure required the least number of changes in my build automation and mozconfig files
-
WG9s
previously the comm-repo just lived in comm-253 and was also a l10n repo there and mozilla was below comm
-
nsITobin
I deff have .. opinions.. on the efficiency and aesthetics of directory structures.. I'll try and keep them at a minimum ;)
-
WG9s
also allmy opjeirs are in comm-253 because that is how it all worked when comm on top
-
WG9s
so is now kind of funky but waht i am used to
-
nsITobin
yeah soonish i will be doing a 253 patch to kill off comm-on-top leftovers
-
nsITobin
I considered fixing it up.. but .. its a timesink on build system that keep changing so perpetual timesync
-
nsITobin
if I had the time this year and if the taskcluster crap wasn't timelimited i'd just embark on a huge ass mission to just wholesale port the entire codebase to 115's build system so its one and done.. buuuuuuut
-
WG9s
just letting you know why the tar file make the directory structure it does
-
WG9s
fut you can obviously do the same to get the tar file poor mans g bundle. sut clone the 2 ptabod reps the way tyou ant specifiying --noupdate so the tar file is smaller aquuwirrel it away and just untar and then pull and update to get the working repos updated. works better than tring to reclone for me
-
nsITobin
-
WG9s
OK so where do i find the actual aptch filess and why are there 2 comm-central sections in this?
-
nsITobin
typo
-
nsITobin
fixed it
-
WG9s
was one supposed t e mozilla-central?
-
nsITobin
ye
-
nsITobin
where .. clone the repo.. browse the repo.. download zip or tarball
-
WG9s
oh ok so in the downloads
-
nsITobin
yep
-
nsITobin
figured.. well this thing I run already DOES a lot of this
-
WG9s
the mozilla part is an issue so will need to get our Mr phbulous IanN involved.
-
nsITobin
mozilla will never accept this patch
-
nsITobin
and CERTAINLY not from
-
nsITobin
me
-
nsITobin
i filed it tho
-
nsITobin
cause .. its legit
-
nsITobin
also see if it gets ignored or if i get drummed out of bugzilla for it
-
nsITobin
you MUST apply the patch tho in order to run seamonkey.exe
-
WG9s
he is the only one of us who has a phbricator account so silly mye Blues Brother fan when I need him to do a mozilla patch refer to him as Mr Phabulous.
-
nsITobin
WG9s: i immidately thought.. Blues Brothers my self
-
nsITobin
BinOC/Code should be fairly easy to navigate its rather basic and laye dout much like github USED to be
-
nsITobin
WG9s: I can make you an account if you want and enable the issue tracker I just have it disabled cause I am not using it and to avoid the horde of seo bots
-
nsITobin
you could also add my repo as a remote to the other one and pull the tobin branch as well
-
WG9s
also no one other than me seems to ever know sho VIni Lopez is. he was original drumer for Bruse SPrinsteen on the first 2 albums but anyway a couple of years ago I bought a t-shirt at Porta the venue tat was once the student prince where Brusce used toplay backin the day. so it was a reprint of the poster for a performance by the band. So was proucly werain me new shirt that night at the...
-
WG9s
...stone pony for another show ans was sitting with VIni and e fiance Dawn sees and ways to Vivi weren;t you at that concernt and VIini, who always has a story, says.
-
nsITobin
I've heard the name but didn't remember anything else
-
nsITobin
all the m-c patch does is add support for any non-thunderbird comm app to ./mach run and expands the provision thunderbird already has under their ifdef with another SM is setting in moz.configure
-
nsITobin
-
WG9s
You remember in the Blues brothers movie when they payed at Bob's Country Bunker and pretended to be the good ole boys and after the event the band is outside waiting for their money and issue was there bar bill was $300 more than what they got paid for performing. so Vini says that is who that show at the Student prince wnent.
-
nsITobin
it's a patch only someone who has been deep in mozbuild for years would be able to find and so easily rectify
-
nsITobin
WG9s: yep
-
nsITobin
love that movie
-
nsITobin
heh really
-
WG9s
funny thing is probably would have gotten the same story had I been wearing the Bob's Vountry Bunker t-shirt i have "We play both kinds of music country and western"
-
nsITobin
so was the movie scene based on it? or just similar
-
WG9s
i aalso have a Ray's Music machine t-shirt that no one gets
-
nsITobin
nice
-
WG9s
and semi related to the movie i also have john Lee Hooker t-shir "Boom Boom" was featured in the move on the street after elaving Rays but that is not realted to why I have that shirt
-
WG9s
hmm what is you opinon of the movie spaceballs
-
WG9s
i seem too have the same sense of humor as mel brooks. only isue with spaceballs was a lot of the jokes i guesed the pundhline before it happend
-
WG9s
likd the Druish pricess joke and coming the dessert
-
WG9s
and 12345 that's the combo on my luggage
-
WG9s
nsITobin: OK so i need to add the TOP-CONTRIB patches after allthe other TOP patches and the WIP buids at the end of series so at the top of the queue?
-
nsITobin
the series file is already ordered
-
nsITobin
and all fit
-
nsITobin
just swap em in to .hg/patches for comm and mozilla
-
WG9s
for now will ust add them all locally ned to do it this way to get frg and IanN to permit lading on gitlab
-
WG9s
like all of ths=is to be real patches with real bugs and able to get bug closed do land a ptch on comm or mozilla central and removed from the queue so that is wahy i asked for seperate patches i need to add these on top of the gitlab queue rahter than ust rplaceng th whole queue with our. thy like baby steps
-
nsITobin
so what do you want me to do exactly?
-
WG9s
nothing for now just waying i am going to contue doing my build wit the gitlab queue and then apply your additional aptches on top if tht afils I will get becak to you
-
WG9s
just try8ing to this in a say that they are more likely to approve
-
WG9s
I am resuming the other patches that came from gitlab have not been modified? if they have been that info would help
-
WG9s
but let me just try building and we shall see if it all works
-
WG9s
the way i think they would prefer
-
nsITobin
only the ones I indicated were modified
-
WG9s
yes the ones that say revised.
-
WG9s
ok i can do it then
-
nsITobin
I had it as an "overlay" so you could just copy my subdirs in and edit the series file but i thought this would be easier for you to consume as-is
-
nsITobin
for WIP my scripted process will likely sed the contents in before the general stop patch was gonna do the same for central as well
-
WG9s
they are WIP anyway so not really approved by anyone so i will probably just replace the 2 revised ones
-
WG9s
anyehing els seems too comlified
-
nsITobin
?
-
nsITobin
the revised patches are useless without my follow up contrib ones
-
WG9s
no problem i just needed to understand better now i know how to get tis so that frg and IanN don;t complain fi the exiting patches you revid=sed were not wip then they would ave santed a new patch to apply after to produce the desired result but given they are only WIP I think I can just change them
-
WG9s
ok were are on teh A-Team now. Isn;t it great when a plan comes together
-
WG9s
nsITobin: so my plan is to just update the 2 IP patches you alters on the central gitlab aueue and then take the new patches and just add them locally
-
WG9s
does that make sense to you?
-
WG9s
WIP not IP patches
-
nsITobin
-
nsITobin
that is why I revised them
-
nsITobin
to exclude those bits cause this was a rollup it seems addressing bustage not bugs but still citing bugs
-
nsITobin
in one you replaced about.js with thunderbird's about redirector as-is .. my patch excludes those and related mods for about redirector and copies it over again in its esmodule form and modifies it for seamonkey specifically
-
nsITobin
and aboutredirector needed revised so i can acess about pages
-
nsITobin
WG9s:
-
nsITobin
since I could not actually convert the original nsAbout something special about that version doesn;t make the transition
-
nsITobin
having to do with mozilla killing about: its self
-
nsITobin
so as you did I copied the about redirector and updated it with SM contents and also mapped the about: about page to about:version and updated the consuming code for it
-
WG9s
yes i should have told you two changes one was the about redirector i was not that willing to try to do correctly without the UI working so knd of a chicken and egg isue I guess also probaly sme issue with somponents.conf files I just laded the TB about rediredtor on sute to get the build to work becuase that was my directive just keep it building we don;t care if it works attitude
-
nsITobin
and that was what you were faced with and i understand that
-
WG9s
but tht is hy it had WIP if i thought it was correct it sould have been landed inthe gitlab queue
-
nsITobin
no problem with the magic of mq
-
nsITobin
;)
-
WG9s
i suspect is wame issue with oall the WIP patches without a orking UI it is difficult to do a rela patch
-
nsITobin
I am using moz dev and rel my self to aid my mental mapping
-
WG9s
so I amopeful that fi the UI works with your stuff maybe we can get the WIP off of all the pending patches
-
WG9s
they are all WIP becuase no way to test if they actually work or just allow te build to work
-
WG9s
frg_Away: hi
-
frg_Away
WG9s nsITobin all hi
-
nsITobin
remember WG9s I just wanna open some options up so seamonkey isn't YET AGAIN forced down one specific path because everything else has been blocked or someone without some specific skills doesn't bother to contribute for a decade...
-
nsITobin
with*
-
nsITobin
and yes I am refering to my self.
-
nsITobin
hey the frg_Away
-
nsITobin
so WG9s I would need TOP-CONTRIB-about-redirector-jscomp2esmodule.patch approved for inclusion if you swap out the revised WIP-1783623-port1524687-suite.patch and WIP-9999999-port1770994-suite.patch and devtools one is important too those frankly should be sent to central
-
nsITobin
along with the flt branding patch and global dtd removal the latter has a bugzilla bug i'd just have to find it
-
WG9s
nsITobin: not sure you understood what is said I took the two revised QIP patches and landed them on 12.53 gitlab queue and am not adding all the new patches locally in my builds. i am hoping that works and is easier for frg and IannN to follow
-
WG9s
so the ruslt supposedly should be the same
-
nsITobin
yes the two revisions and the about redirector patch eq the same as what you did only adapted and brought to functionality
-
nsITobin
thanks to mah buoy
-
nsITobin
;)
-
nsITobin
also devtools
-
nsITobin
rename "Nightly Experiments to Firefox Labs"
-
nsITobin
that son of a bitch
-
WG9s
nsITobin: all I did was land the TB version as a plceholder to make the build succees I should have made that more clear. I knew it was wrong but did not want to try to do a real fix without a working uI
-
nsITobin
gijsk is one i interacted with.. stealing BinOC branding ideas.. i should feel honored.. tho puts Mozilla on the same level as XP People lol
-
nsITobin
well the real issue was it wasn't an esmodule you did it when it was still a jsm
-
nsITobin
figured hell may as well pull the same trick then debug it
-
WG9s
same for the components.conf files I changes
-
WG9s
adn/or dreated
-
WG9s
that was all never tested pretty sure wa not correct also
-
nsITobin
that i was editing but it confused me so i just rewrote it from scratch.. cause the thunderbird about pages and unlike jar manifests I don't yet have a glance and know what I am doing skill yet with it.. I have to .. READ
-
WG9s
but not being able to get the UI to work, impossible to test
-
nsITobin
well A Ui works
-
nsITobin
that can help fix THE UI if someone were so inclined
-
WG9s
so see then
-
WG9s
that is what we needed
-
WG9s
i did not know what needed to be done and would have probably learned a lot fixing, but the powers the be were on this we don;t care thing
-
nsITobin
I think my main focus on central is those things like es conversion flt translations help you with buildabiliy and making it otherwise useful while I also basically build that compainion webrunner out of its frame because its perfect.. and everything is just a series of easily managable and semi-easy refreshable patches and I absolutely cannot be more thrilled to do stuff..
-
WG9s
but if this works I think the just try to keep it building will be changed to keep it working
-
nsITobin
WG9s: there is no manual for this
-
nsITobin
no guide to follow
-
WG9s
anway tring to set up to do a new build now
-
nsITobin
bugs sure but depending on the bug
-
nsITobin
i do warn you WG9s many emotions may be felt when you actually ./mach run with my patches .. just a warning
-
nsITobin
for me it was a huge amount of excitement but also along side some rage at what Mozilla has done and disappointment at how much is gone
-
nsITobin
OH yeah.. --enable-buoy in mozconfig WG9s
-
nsITobin
i had it as optional so you could just build with devtools and use --chrome as well
-
nsITobin
speaking of devtools
-
nsITobin
frg_Away: on wip and release we need to do a patch that either conditionally factors out customizableUI in devtools or just ship customizeableui so it will shut up ala thunderbird
-
nsITobin
-
nsITobin
-
WG9s
nsITobin: either of us
-
nsITobin
eyah but i haven't been paying much attention to frg_Away ;)
-
WG9s
nsITobin: frg has been more like aweay ** 2 lately. sould be beter going forward.
-
WG9s
nsITobin: frg is the one who asked me to work with you on this.
-
WG9s
when he has said he is out of pocket lately he has been really out of pocket
-
nsITobin
no problem
-
nsITobin
I remain aware that I am proding .. alot but just so I don't have to prod much later
-
nsITobin
and me jumping into things CAN be disruptive
-
nsITobin
if the_bot were here he would tell you "Umm I think Tobin is a mozilla agitator and is known to hang out in #seamonkey" or something to that effect
-
nsITobin
and then grumble about C++
-
nsITobin
WG9s: so what now boss :P
-
WG9s
weait to wee what my builds do. and I am not your BOss do what you want to do
-
nsITobin
chief?
-
nsITobin
chef?
-
nsITobin
LOL
-
WG9s
oh was going to make a get smart joke but then you went to the stupid joke ad with the guy painting the endzone at arrowhead stadium painting chefs instead of chiefs
-
nsITobin
i would have gotten the get smart reference lol
-
nsITobin
love that show
-
nsITobin
i wish I had pirated it back when I used to priate shit
-
nsITobin
I quit pirating things when I moved to texas..
-
nsITobin
let's see what's on the intellectual property violation drive...
-
nsITobin
classic television.. bewitched carl sega's cosmose, Dragnet 1967, I dream of Jeannie, Mash, Monty Python, Addams Family but not the munsters :( I HAD I love lucy but its fallen off the edge guess I needed space..
-
nsITobin
oh and Hogan's Heros
-
nsITobin
WG9s: that is what I have on tap classic tv wise
-
nsITobin
oh and twilight zone and outerlimits (TOS)
-
nsITobin
WG9s: Nick at Nite shows all of em at one time except the last two and cosmos
-
WG9s
nsITobin: I updated my
wg9s.com/comm-central page to document the canges in addition to gitlab queue to be included
-
WG9s
nsI i thought i was the only ADDams family and not the Munsters guy
-
WG9s
but then a Bob Marley tribute band had a guitar player named Hohn DiCarlo and i always asked him ho his mother Lily was
-
nsITobin
fun
-
WG9s
nsI but so far build has not crashed yet will keep yu updated
-
nsITobin
if you are building with --enable-buoy some tips the browsing UI is primitive atm you enter an address and press go and it does it.. no enter no urlbar update very prelem not much more than I did on my own from scratch
-
nsITobin
back forward reload and stop work.. new windows don't downloads do but no UI
-
nsITobin
and no context menu either
-
nsITobin
yet
-
nsITobin
WG9s: I would LIKE to either eliminate package-manifest and go back to NO_PKG_FILES or do a heavy wildcard on most stuff and only keep the stuff relevant for mac build specifications namely the binary files but wildcard the chrome and shit
-
nsITobin
cause package-manifest is such a bitch to do especially with conditionals
-
nsITobin
huge timesink it is
-
FakeTobin
Went to store back later
-
WG9s
oh i screwed up doing patches in wrong order fisng it now trying again
-
WG9s
nsITobin: soi screwed up had to strt over i had 2 windows pen wone with the series fie and one with an ls of the patch files when I created my file to ist the patches to install i copied fomr the ls instead of the series wo ws trying to instll the patches in entirely the incorrect order
-
nsITobin
WG9s: I have returned with much foodstuffs
-
nsITobin
also broke as hell now LOL
-
nsITobin
oh ffs
-
nsITobin
1:23.40 error: failed to get `cubeb-coreaudio` as a dependency of package `gkrust-shared v0.1.0 (C:\mozdev\seamonkey-central\toolkit\library\rust\shared)`
-
nsITobin
1:23.40 Caused by:
-
nsITobin
1:23.40 failed to load source for dependency `cubeb-coreaudio`
-
nsITobin
1:23.40 Caused by:
-
nsITobin
-
nsITobin
1:23.40 Caused by:
-
nsITobin
1:23.40 failed to clone into: C:\Users\mattatobin\.cargo\git\db\cubeb-coreaudio-rs-f1e4b78a32bca2fa
-
nsITobin
1:23.40 Caused by:
-
nsITobin
1:23.40 attempting to update a git repository, but --frozen was specified
-
nsITobin
expected a successful build when I got back
-
nsITobin
so much for that
-
nsITobin
didn't pull comm again..
-
nsITobin
well kicked off again
-
nsITobin
... why is my patch for nsSuiteApp not in my queue?
-
nsITobin
well least it won't cause a clobber for WG9s once he gets his build
-
nsITobin
errg
-
nsITobin
cause I overwrote it because it was a revised one
-
nsITobin
1908725 the followup parts need added, that's right
-
WG9s
so far three of the patches did not apply so working on bilding with the others to make sure at least build is not broken then will ook at them to see if simple fixes or if needing to go back to you
-
nsITobin
what didn't apply?
-
WG9s
nsITobin: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
WG9s
TOP-CONTRIB-null-dll-blocklist-bustage.patch TOP-CONTRIB-about-redirector-jscomp2esmodule.patch and TOP-CONTRIB-diagnostic-buoy-component.patch
-
nsITobin
how do they not apply I don't understand
-
WG9s
this is after i took the two you updated already in gitlab and did the update in gitlab central
-
nsITobin
what ones did you take?
-
WG9s
and then di d a whold fresh comm-central clone and patched with the gitlab queues then tried to apply your TOP-CONTRIB patches in the oreder in your series file and those thr=reee all fieled to apply
-
nsITobin
why does it not apply?
-
nsITobin
what do I do about it?
-
WG9s
did not look at the second two just decided skip for now and look at tomorrow but the first one seems to be dding stuff in a non existent area of code in suite/moz.configure
-
nsITobin
if you don't have those nothing else matters though
-
nsITobin
you can't test if they work
-
WG9s
i could just put that in anywahere i guess but just tring to make sure yhe rest of things will still compile so that i can look at this in the morning
-
WG9s
i bet the other 2 issues are similar
-
nsITobin
why does it apply for me
-
WG9s
good question because the code in the context does not seem to exist
-
nsITobin
my patches were fetched this morning
-
WG9s
so it cant scertain where to put it perhaps it will apply if you say -F7
-
nsITobin
and then based on em
-
nsITobin
i can try to do a qrefresh on em and commit them and see
-
WG9s
but did you apply against a hg cehckout or a hg checkout with the seamonkey-central-patches gitlab quwue applied?
-
nsITobin
clone the downloaded bundle update the upstreams pull and update then copy patches qpush em
-
WG9s
or there is a change i should have applied to the comm part that is not a TOP-CONTRIBUTOR patch
-
nsITobin
that is the essence of what I have learned to do
-
WG9s
how strange
-
nsITobin
the revised WIP patches
-
nsITobin
yeah that's why I am confused
-
nsITobin
it SHOULD work
-
nsITobin
but I am refreshing the entire queue and will commit it
-
nsITobin
also modify port 1908725 patch so it includes TB's followups via copypasta
-
WG9s
so clone the source then talke the mozilla and comm patches from the seamonkey-central-patches gitlab and apush them all
-
nsITobin
got lost in the shuffle
-
WG9s
then i tried adding your new stuff lcoally
-
WG9s
anyway without those 3 still now UI but it still builds and runs and extis with no errors.
-
nsITobin
just a sec have to pull chicken out the oven
-
WG9s
so the patches I am still aplhying are doeumented here
wg9s.com/comm-central
-
WG9s
I also rebased the mozilla patch becaseu m automation balked at the very large offset required on that patch
-
WG9s
anyway I am done for today and will be up early tomorrow to try to wort this
-
nsITobin
sorry it hasn't been more productive WG9s_Away