-
tomman
hmmm, noticed my hack of Redirector still works, but the preferences page is broken again
-
tomman
wonder what changed, I haven't upgraded my nightly in a good time
-
tomman
wait, a jQuery error!?
-
tomman
their built-in jQuery 1.6.2 suddenly broke out of the blue!?
-
tomman
can't tell where I broke - unlike the developer console, the error console won't pinpoint the exact place, just "line 16"... which is several dozen hundred characters long
-
tomman
and the developer console doesn't output addon errors, or errors from chrome:// URLs
-
tomman
Fecha: 4/5/24 5:36:35 p. m. VET
-
tomman
Error: TypeError: i is undefined
-
tomman
Archivo fuente: chrome://redirector/content/js/jquery-1.6.2.min.js
-
tomman
Línea: 16
-
tomman
OK, switched to the unminified version of jQuery 1.6.2, and now it's clear what's failing
-
tomman
> // Make sure that if no value is specified for a checkbox // that it defaults to "on". // (WebKit defaults to "" instead) checkOn: ( input.value === "on" ),
-
tomman
div = document.createElement( "div" ) => this works
-
tomman
input = div.getElementsByTagName( "input" )[ 0 ]; => this returns null because... it returns an empty array
-
tomman
it's a sort of compatibility test that now fails
-
tomman
> Flattening unsafe node (descendants are preserved). Element: input.
-
tomman
oh, I get this warning straight from the browser engine
-
tomman
div.innerHTML = " <link/><table></table><a href='/a' style='top:1px;float:left;opacity:.55;'>a</a><input type='checkbox'/>";
-
tomman
this line on jQuery creates some test stuff for doing some compat tests
-
tomman
but somehting deep in Gecko is now... eating things?
-
tomman
Removing unsafe node. Element: link.
-
tomman
Removed unsafe URI from element attribute. Element: a. Attribute: href.
-
tomman
Flattening unsafe node (descendants are preserved). Element: input.
-
tomman
that innerHTML line triggers those three warnings (which DO get registered on the dev console, not on the error one
-
tomman
of course, when the input.value test runs, it finds out a null reference and blows up badly
-
tomman
funny enough those breakups do NOT happen on a ordinary http(s):// URI
-
tomman
but just on a chrome://
-
tomman
somewhere in nsTreeSanitizer.cpp
-
tomman
I can't just dump jQuery since the settings page rely heavily on it, and modifying jQuery is also tricky