libera #seamonkey

4 Sep 2022

Surfing the net has never been so suite | SeaMonkey Release:2.53.20 Beta: TBA | seamonkey-project.org/releases | This channel is logged at logbot.thereisonlyxul.org/seamonkey | SeaMonkey Nightly:2.53.21b1pre Archive archive.seamonkey-project.org/nightly | c-c (OPEN ) , c-253 (APPROVAL ONLY) | R.I.P. WG9s

• 00:51
  buc
  tomman: njsg: frg: Regarding ircbot.comm-central.org:8080/seamonkey/20220822#c197807 ...
• 00:51
  buc
  Reverting 1485179-2 fixes the issue.
• 00:53
  buc
  Strange commit. First, they increase bitfield size from 3 to 4, but then eliminate this change using "& 0x7" in an assignment.
• 00:54
  buc
  But do it in one place only. If you do it (& 0x7) in all two places (which seems the same as reverting of the patch), the problem gone.
• 00:56
  buc
  I believe it is better to reverth this one, since it affects SM now. If somebody have a time, please bisect nightly Firefox builds to determine where and when this issue gone there.
• 00:56
  tomman
  tables are hard, let's go shopping~
• 00:59
  » a-865 waves to buc
• 00:59
  buc
  a-865: Hi
• 01:02
  buc
  Instead of 1485179-2 reverting, just add "& 0x7" into gitlab.com/seamonkey-project/seamon…ayout/tables/nsTableFrame.cpp#L5371, the same way as it done in gitlab.com/seamonkey-project/seamon…ayout/tables/nsTableFrame.cpp#L5330
• 01:06
  buc
  tomman: Do you have a reliable test case for ircbot.comm-central.org:8080/seamonkey/20220824#c197839 ? I opened the link, but there was no TypeError messsage in my case.
• 01:07
  tomman
  buc: it seems they updated their pile of Javascript vomit
• 01:08
  tomman
  I still get the weak map key error, but this time caught inside a Unhandled Promise rejection from their Javascript framework vomit
• 01:09
  tomman
  so far it's the only site where I've seen the weak map key issue